Swift 6 Compatibility #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 81.14% 81.79% +0.65%
==========================================
Files 11 11
Lines 281 280 -1
==========================================
+ Hits 228 229 +1
+ Misses 53 51 -2
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Thank you @Supereg for fixing this!
Seems like we have a small amount of warnings (only in the tests) that will be errors in Swift 6 that surface as part of enabling this in this PR. Would be great to address them as part of this PR.
1 task
PSchmiedmayer
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Swift Concurrency
♻️ Current situation & Problem
Updates the flag name.
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: